Properties #45
Merged
Properties #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2017 17:55
• Smart map merge • Element Properties • Nested Properties • Element • Element Group
update documentation to variables actually makes core docs useful add em, rem, to-unit to documentation to make those more transparent add links to external resources where appropriate still a few things to work out, but a really great start
added 4 commits
April 24, 2017 10:53
josephgknox
pushed a commit
that referenced
this pull request
Feb 28, 2018
* EARTH-000: added classes to views, fields, and blocks through preprocess.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready
After some experimentation:
propertiesmixin calls _nested properties and smart merge to provide a hook for extensibility_nested-propertiesmixin outputs property:value pairs (nested recursively with nested sass maps)smart-mergewill merges sass maps (or returns the provided map)buttonmixin leverages these for buttons, but we still have the option of using placeholders. This requires some in-person discussion, i thinkbasehas been completely refactored and documentedvariables, functions, mixinsare now useful since they cross-reference each other