Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handoff #51

Merged
merged 37 commits into from
Dec 18, 2017
Merged

Handoff #51

merged 37 commits into from
Dec 18, 2017

Conversation

kgcreative
Copy link
Contributor

Ready for review

Unreleased ( target: master 1.0.0-alpha3 )

Added

  • package.json only includes the /core folder when the project
    is installed via npm install
  • bourbon, bourbon-neat, neat-omega, font-awesome and
    normalize.css are included via bundledDependencies in package.json
  • .sass-lint.yaml now tracks recommended settings from sass guidelines
  • added DOCUMENTATION.md to docs folder to track current state of scss documentation
  • added dependencies.md to docs folder with links to their project or NPM sites

Fixed

  • h3 in base/_typography.scss now correctly picks up h3
    heading styles from the map instead of h2

Changed

  • the material-shadow mixin passes through to the material-shadow
    function instead of duplicating the code
  • the card mixin now uses the material-shadow function instead of
    the mixin
  • Breaking: reversed $hocus and $pocus variables in variables/_typography.scss to
    better conform to their expected semantics.
    $hocus is now hover + focus, and $pocus is a little more (hover + focus + active).
  • Potential Breaking change: $decanter-default-settings
    renamed to $decanter-settings--default to conform to the rest of our
    variables $variable, $variable--default convention
  • Moved bourbon, neat, neat-omega from decanter-variables.scss
    to decanter-utilities.scss
  • Flexbox overrides have been added to flex-items-per-row.scss when
    $center-grid is true
  • cleaned up sassdoc documentation
  • cleaned up rollup files to be more consistent
  • spacing and linting pass on many mixins and maps
  • renamed core/decanter.scss to core/_decanter.scss
  • upped dependency version numbers for bourbon and bourbon-neat and normalize
  • shuffled sassdoc groups to be more useful

Kevin Garcia and others added 30 commits May 24, 2017 12:16
move bourbon, neat, neat omega from variables to utilities (now that …
adabe64 
…settings are called at runtime)
!fixup neat (duh)
524ae8d
!fixup base/heading 3
1a8f4cf
@kgcreative
Add flex overrides
6eb541c
• Specifically only include the /core folder when pulling the project…
bef139e 
… from NPM (We don’t need docs, examples, utilities in the node_modules folder if we’re not developing. It’s just cruft)

• Include bourbon, bourbon-neat, neat-omega, font-awesome, and normalize as part of the bundled dependencies (so that downstream implementations don’t have to specifically import them in their package.json, and to better manage potential semver conflicts if a dependency is updated)
Update semver to expected release tag.
3ad1155
remove extraneous group
3e372db
add .package-lock.json file
2a70771
up version number in readme
755b273
Modified sass lint to track https://sass-guidelin.es/
bffee64
tidy up sassdoc to be actually useful
b0e5bee
update sasslint
eabc2ce
Consistency, spacing, resolving linting errors.
4cbb137
consistency pass
dd7aec1
lint and documentation pass. Mostly ensuring proper elements and func…
68d0269 
…tions are being linked and referenced
resolving consistency and linting issues
86b6b7e
resolving consistency and linting issues
7748d27
resolving consistency and linting issues
f617008
resolving consistency, documentation and linting issues
959dc10
dependency management
9d9aa37
linting, consistency and docs
1f3b529
Regenerate docs and css
a55333a
Merge branch 'homesite17' into handoff
bac9d9e 
* homesite17:
  Add flex overrides
  !fixup base/heading 3
  !fixup neat (duh)
  move bourbon, neat, neat omega from variables to utilities (now that settings are called at runtime)

# Conflicts:
#	core/utilities/_decanter-utilities.scss
#	core/utilities/mixins/layout/_flex-items-per-row.scss
#	core/utilities/variables/_decanter-variables.scss
regenerate docs
794f1fb
docs, linting, etc
1c83064
no message
a58a25e
@kgcreative
Update and rename DOCUMENTATION.MD to DOCUMENTATION.md
8456eeb 
flesh out documentation structure
@kgcreative
Create dependencies.md
97a3e87
conform to other map—default() / map() nomenclature for consistency
e64b587
reflect default variable change
be5c065
@kgcreative kgcreative requested a review from sherakama August 31, 2017 00:27
sherakama
sherakama approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama sherakama merged commit 204d54e into master Dec 18, 2017
@sherakama sherakama deleted the handoff branch December 18, 2017 18:34
sherakama added a commit that referenced this pull request Jan 15, 2018
@sherakama
Issue #51: Add KSS styleguide generator.
376a2bf
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgcreative @sherakama