D8 core 724 button hover

[cjwest]

READY FOR REVIEW

Summary

Hover and focus should rely on something other that a color change. I put in an underline to indicate the change
https://stanfordits.atlassian.net/browse/D8CORE-724

Needed By (Date)

• When does this need to be merged by?
  Soon.

Urgency

• How critical is this PR?
  Would like it for DecanterPalooza

Steps to Test

Check out this branch
Verify the button hover, active, and focus work as expected

Affected Projects or Products

Associated Issues and/or People

• JIRA ticket: https://stanfordits.atlassian.net/browse/D8CORE-724

See Also

• PR Checklist

[sherakama]

@kerri-augenstein re: https://stanfordits.atlassian.net/browse/D8CORE-724

[sherakama]

Thanks @cjwest,

If you're looking to get rid of the button jumping have a look at the examples on this page for how they did it: https://www.w3.org/TR/wai-aria-practices/examples/button/button.html

I also noticed that their hover state differed from their focus state.

[yvonnetangsu]

Hey @cjwest , agree that we need something other than color change for button hover/focus state. What do you think about just adding an underline to the text instead? That would work better in the buttons in the CTA component for example.

[cjwest]

Hi @yvonnetangsu,
I appreciate your thoughts on this! I think that this should have styling that works well with the rest of the site. I'm happy to switch to underlines.

Let me know if you want to run with it and create a PR. Otherwise, I can propose something.

[sherakama]

@cjwest go ahead and run with it.

[cjwest]

Hi @yvonnetangsu,

I switched from the outline to the underline. Take a look and if you like it, hit "Squash and merge".

[yvonnetangsu]

@cjwest @sherakama Hm....I don't think this PR is for merging into master - looks more like a v6 merge to me 🤔

[cjwest]

Oh, thank you, @yvonnetangsu, for the clarification! I was debating that.

[yvonnetangsu]

Oh, thank you, @yvonnetangsu, for the clarification! I was debating that.

Did you do a npm run build, @cjwest ? Looks like all the dist/ asset files were removed.

[sherakama]

Proper branch set and compiled.

Ready for review.

[yvonnetangsu]

Looks good. GTG!