Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Restore .centered-container and fix webpack alias for font-awesome. #605

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

sherakama
Copy link
Member

READY FOR REVIEW/

Summary

  • Restores missing layout helper class.
  • Fixes webpack build

Needed By (Date)

  • Whenever

Urgency

  • low/medium, webpack builds fail at the moment.

Steps to Test

  1. Check out this branch
  2. Compile npm run build
  3. Review markup

Affected Projects or Products

  • V6+

See Also

@sherakama sherakama temporarily deployed to Tugboat January 10, 2020 21:43 Destroyed
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build works now - thanks! Is there an easier way to preview locally when one pushes to this repo, other than having decanter-web pulling a dev branch of the decanter repo?

@sherakama
Copy link
Member Author

At the moment there is nothing that allows us to build anything previewable just in this repo. That is an obvious pain point and why tugboat is pulling decanter-web for that work. We should think of a solution we would want to build in.

@sherakama sherakama merged commit 4dc2afd into master Jan 10, 2020
@sherakama sherakama deleted the cntr branch January 10, 2020 22:48
@kgcreative
Copy link
Contributor

If you are building with Netlify, you can use build hooks to build deploy previews on either a PR or on a feature branch. https://www.netlify.com/blog/2016/07/20/introducing-deploy-previews-in-netlify/

@sherakama
Copy link
Member Author

Happy New Year @kgcreative

We've got the build previews working on the https://github.com/SU-SWS/decanter-web repo but haven't looked into wiring up this repo. Interesting thought.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants