DECANTER-193: Start of accordion and development environment. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yvonnetangsu FYI. Not much progress on the accordion but I did manage to scaffold a small development environment to help with building out and testing stuff. |
#643) * WIP - added a bit more accordion twig/json/scss stuff and dev page bits expanded upon Shea's decanter-193 branch; some things are there temporarily * Chipping away at the accordion scss * beginning js and style fixup * More aria js and scss * Change +/- icon when title is clicked * Try a ul structure for the accordion itself which is more sematic but allows for more flexibility compared to dl * style chipping * Add CTA button and title * Add expand/collapse all buttons and functionality Co-authored-by: Yvonne Tang <ytang2@stanford.edu>
|
I know this still need some work but wondering if it's ok to merge as is? It would be nice to get that new development environment @sherakama set up into master 😄 |
|
Let's mark it as experimental and merge it in. |
Cool. Thanks!! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)See Also