Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

D8CORE-2630: Updating the alert basic link hover colors & underline #730

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • We need to change the link colors on hover/focus states for our alerts to meet accessibilty.

Needed By (Date)

  • Sept 3

Urgency

  • High

Steps to Test

  1. Checkout this branch
  2. Try out it out in the developer/ playground.
  3. Look at each alert variant which can be found at /patterns/alert and make sure that the links' hover and focus only show an underline and do not change the text color. Verify the Info alert links are not just underlined in normal state.

Affected Projects or Products

  • Stanford Basic
  • SOE
  • Adapt (I think)

Associated Issues and/or People

See Also

@jenbreese jenbreese requested a review from sherakama September 3, 2020 19:31
@sherakama sherakama temporarily deployed to Tugboat September 3, 2020 19:31 Destroyed
@cjwest
Copy link
Member

cjwest commented Sep 3, 2020

👏

@sherakama sherakama merged commit 2009e2b into master Sep 3, 2020
@sherakama sherakama deleted the D8CORE-2630 branch September 3, 2020 20:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants