New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

V7 colors #787

Merged

yvonnetangsu merged 5 commits into v7 from v7-colors

Jan 12, 2021

Member

yvonnetangsu commented Jan 11, 2021 •

edited

Loading

READY FOR REVIEW

Summary

Update v7 color variables. Add Digital Green, replace Fog with Foggy (old Fog color is now su-color-foggy-light). Bright Blue is now Digital Blue.

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Look at code

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist

yvonnetangsu added 2 commits

January 11, 2021 02:41


          Update identity colors

873ba73


          Change color fog in Alert to foggy

8161dbd

sherakama temporarily deployed to Tugboat

January 11, 2021 10:50

Destroyed


          npm run publish

sherakama temporarily deployed to Tugboat

January 11, 2021 10:53

Destroyed


          fix color names

716c23f

sherakama temporarily deployed to Tugboat

January 11, 2021 10:58

Destroyed


          fixup

28901cc

sherakama temporarily deployed to Tugboat

January 11, 2021 22:19

Destroyed

yvonnetangsu requested a review from sherakama

January 11, 2021 22:29

Member

sherakama commented Jan 12, 2021

@yvonnetangsu How does this relate to #694?

Member Author

yvonnetangsu commented Jan 12, 2021 •

edited

Loading

@yvonnetangsu How does this relate to #694?

#694 looks stale to me - those colors name mentioned have since been changed. However, the colors themselves or similar updated versions of them are in v7 branch but with different new names (@kerri-augenstein suggested some of these changes)

Member

sherakama commented Jan 12, 2021

Can we close #694 then in favor of this one?

Member Author

yvonnetangsu commented Jan 12, 2021

Can we close #694 then in favor of this one?

Yes, I believe so. I'll ping @katrialesser tomorrow and let her know since she was working on #694. The new colors are in branch v7 and in the v6 PR so she'll be able to pull from either if the colors are needed.

sherakama approved these changes

View reviewed changes

Member

sherakama left a comment

GTG

sherakama mentioned this pull request

New colors that soe and saa want to use #694

Closed

yvonnetangsu merged commit d448d37 into v7

yvonnetangsu deleted the v7-colors branch

January 12, 2021 19:09

Member Author

yvonnetangsu commented Jan 14, 2021

@sherakama Think we could cut a new release maybe after merging Rebecca's branch?

Member

sherakama commented Jan 15, 2021

Sure. Can do.

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet