New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

No more components #792

Merged

sherakama merged 3 commits into v7 from no-more-components

Feb 4, 2021

Member

sherakama commented Feb 4, 2021

READY FOR REVIEW

Summary

Removes components

Needed By (Date)

Whenevs

Urgency

low

Steps to Test

Check-out/Read the code
Do a build to see it still compiles

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist


          Removed components.

cb3283f

sherakama had a problem deploying to Tugboat

February 4, 2021 05:42

Error

sherakama changed the base branch from master to v7

February 4, 2021 05:43

sherakama changed the base branch from master to v7

February 4, 2021 05:43

sherakama requested a review from yvonnetangsu

February 4, 2021 05:43

sherakama assigned yvonnetangsu


          Run npm update.

ea7a9a1

sherakama had a problem deploying to Tugboat

February 4, 2021 05:46

Error


          Run npm run publish.

6d5c0b7

sherakama had a problem deploying to Tugboat

February 4, 2021 05:46

Error

yvonnetangsu approved these changes

View reviewed changes

Member

yvonnetangsu left a comment

Looks good to me - GTG merge when you're ready.

sherakama merged commit 63bee8f into v7

sherakama deleted the no-more-components branch

February 4, 2021 05:50

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet