New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adapt-1808: Use TW box shadows for v7 #799

Merged

sherakama merged 3 commits into v7 from ADAPT-1808-shadow

Feb 11, 2021

Member

yvonnetangsu commented Feb 11, 2021 •

edited

Loading

READY FOR REVIEW

Summary

Get rid of our custom box shadows and use TW default
Update our button styles to use TW md drop shadow because that's closer to our previous default
Update preview page

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

See the shadows: https://deploy-preview-799--decanter-v7.netlify.app/#drop-shadows
Look at code

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist


          Use TW default for box-shadows; update preview page

yvonnetangsu changed the base branch from master to v7

February 11, 2021 01:21

yvonnetangsu added 2 commits

February 10, 2021 17:29


          Forgot sample test page code

7fdde56


          add accidentally deleted netlify badge back in

016bb47

yvonnetangsu requested a review from sherakama

February 11, 2021 01:35

Member Author

yvonnetangsu commented Feb 11, 2021

@sherakama Met with Kerri so this one is ready too

sherakama approved these changes

View reviewed changes

Member

sherakama left a comment

GTG

sherakama changed the title ~~Adapt-1808 Use TW box shadows for v7~~ Adapt-1808: Use TW box shadows for v7

sherakama merged commit 3401bc5 into v7

sherakama deleted the ADAPT-1808-shadow branch

February 11, 2021 18:19

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet