Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ADAPT-000: Add options to fontSize.js for the modular scale steps #805

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Feb 26, 2021

READY FOR REVIEW

Summary

  • Added steps in fontSize.js utility which correspond to decanter 6's @modular-typography mixin. It purely sets the font size using the modular scale of 1.25 ratio and responsive variants are generated. This allows for eg, su-text-m0 md:su-text-m1 2xl:su-text-m3 (step 0 = 1em for mobile, step 1 = 1.25em for MD, step 3 = 1.95em for 2XL).

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Looks at code and see that the new font size classes are being generated.

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

…rom modular-typography which are manually scaled down with multiplier)
@yvonnetangsu yvonnetangsu changed the title Added options to fontSize.js for the modular scale steps (different f… Added options to fontSize.js for the modular scale steps Feb 26, 2021
@yvonnetangsu yvonnetangsu changed the title Added options to fontSize.js for the modular scale steps Add options to fontSize.js for the modular scale steps Feb 26, 2021
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama
Copy link
Member

I'm going to need to bring bump to this repo as well. I'll put that on my todo

@sherakama sherakama changed the title Add options to fontSize.js for the modular scale steps ADAPT-000: Add options to fontSize.js for the modular scale steps Feb 26, 2021
@sherakama sherakama merged commit f5667a7 into v7 Feb 26, 2021
@sherakama sherakama deleted the ADAPT-1956-responsive-type branch February 26, 2021 17:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants