Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adapt-000 Remove animation variants but add translate variants #814

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Adapt-000 Remove animation variants but add translate variants #814

merged 4 commits into from
Mar 16, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 16, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Animation variants in TW aren't that useful for us, but we need the translate variants for CTA link icon animation. So removing the animation variants but adding the ones for translate.
  • Add a few spacing steps

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Look at code

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@yvonnetangsu yvonnetangsu requested a review from sherakama March 16, 2021 20:21
yvonnetangsu
yvonnetangsu commented Mar 16, 2021
View reviewed changes
src/plugins/theme/spacing.js
Comment on lines +30 to +33
14: '1.4rem',
15: '1.5rem',
16: '1.6rem',
17: '1.7rem',
Copy link
Member Author

@yvonnetangsu yvonnetangsu Mar 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG2M

yvonnetangsu
yvonnetangsu commented Mar 16, 2021
View reviewed changes
sherakama
sherakama approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@yvonnetangsu yvonnetangsu merged commit 322b37f into v7 Mar 16, 2021
@yvonnetangsu yvonnetangsu deleted the ADAPT-000-animation branch March 16, 2021 21:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama