New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ADAPT-2856: Moving styles from tags to classes #841

Merged

sherakama merged 7 commits into v7 from ADAPT-2856

Jul 13, 2021

Contributor

Lyafel commented Jul 9, 2021 •

edited by sherakama

Loading

READY FOR REVIEW

Summary

Moves base form element styles into components

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Do this
Then this
Then this

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist


          ADAPT-2856: Moving styles from tags to classes

9aaec2d

Lyafel requested a review from sherakama

July 9, 2021 17:13

github-actions bot added the size/s label

sherakama added the beta label

sherakama requested a review from yvonnetangsu

July 9, 2021 19:45


          Fixup!.

f3e73e0

github-actions bot added size/l and removed size/s labels


          Fixup!.

b79c8cd

Member

sherakama commented Jul 9, 2021

Please review. This is a disruptive enough change that I have targeted a beta release for this.

yvonnetangsu reviewed

View reviewed changes

src/plugins/components/form/form-elements.js Outdated Show resolved Hide resolved

yvonnetangsu reviewed

View reviewed changes

tailwind.config.js Outdated Show resolved Hide resolved

Member

yvonnetangsu commented Jul 9, 2021

Just those couple comments, and then we're GTG - thanks!

Member

yvonnetangsu commented Jul 9, 2021

@yvonnetangsu

Please review. This is a disruptive enough change that I have targeted a beta release for this.

And yes, a beta release would be great. We'll update Decanter-React after this get merged in.

sherakama and others added 3 commits

July 13, 2021 09:18


          Update tailwind.config.js

c8f68f2

Co-authored-by: Yvonne Tang <ytang2@stanford.edu>


          Update src/plugins/components/form/form-elements.js

f451145

Co-authored-by: Yvonne Tang <ytang2@stanford.edu>


          ADAPT-2856: Updates and re-package.

3dee99e

github-actions bot added size/xl and removed size/l labels


          Added upgrade note.

7ae9e99

sherakama merged commit 5b71a64 into v7

sherakama deleted the ADAPT-2856 branch

July 13, 2021 16:33

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels