Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update _lockup.scss #846

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Update _lockup.scss #846

merged 3 commits into from
Aug 13, 2021

Conversation

sherakama
Copy link
Member

READY FOR REVIEW/NOT READY

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@yvonnetangsu
Copy link
Member

Hmmm odd....seems like they're still not showing up 🤔
https://deploy-preview-846--decanter-v6.netlify.app/component/identity-lockup/

@yvonnetangsu
Copy link
Member

I sort of remember that the formatting of the twig comments was really finicky. Maybe even moving that comment to the top breaks it because it creates a 2nd paragraph.

@sherakama
Copy link
Member Author

This (https://github.com/SU-SWS/decanter-web/pull/89/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R43)
Will need to change to this branch in order to pull the new build

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG - thanks, Shea!

@yvonnetangsu
Copy link
Member

@sherakama Does this need a beta tag before merging?

@sherakama sherakama added the patch Releases a patch tag label Aug 13, 2021
@sherakama
Copy link
Member Author

We don't have an auto release in v6. I suppose I could pull that back.

@github-actions github-actions bot added size/s and removed size/xs labels Aug 13, 2021
@sherakama sherakama merged commit 8ae53f2 into master Aug 13, 2021
@sherakama sherakama deleted the kssizhard branch August 13, 2021 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Releases a patch tag size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants