Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up, more components and elements #97

Merged
merged 8 commits into from
Apr 18, 2018
Merged

Clean up, more components and elements #97

merged 8 commits into from
Apr 18, 2018

Conversation

josephgknox
Copy link

READY FOR REVIEW

Summary

  • Added several components, elements, and core items (tickets in project represent what is in progress; also cleaned up duplicated or deprecated tickets in project)
  • Cleaned up all KSS and SCSS comments and code spacing for uniformity
  • Ensured modifier classes being used in Twig templates were generating a good-looking default style (e.g., alerts and buttons)
  • Began documenting all items (some more thoroughly than others)
  • Organized components at proper levels in file system
  • Added necessary files for all components, elements, mixins, etc. to be added to style guide (with placeholder text/markup where needed)
  • Added overflow mixin to clean up markup being generated

Needed By (Date)

  • N/A

Urgency

  • N/A

Steps to Test

  1. Pull this branch
  2. Ensure that things are looking good and much more flushed out in local pattern library and style guide
  3. Cleaner code base

Affected Projects or Products

  • Decanter

Associated Issues and/or People

See Also

@sherakama sherakama merged commit 61e0264 into master Apr 18, 2018
@sherakama sherakama deleted the cleanup branch April 18, 2018 22:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants