Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do research and try to implement area location #100

Closed
ckertam opened this issue Oct 31, 2023 · 7 comments
Closed

Do research and try to implement area location #100

ckertam opened this issue Oct 31, 2023 · 7 comments
Assignees
Labels
backend Related to backend frontend Related to frontend p:mid Address eventually
Milestone

Comments

@ckertam
Copy link
Collaborator

ckertam commented Oct 31, 2023

We are already using Google Maps API to show location. But it's requested to be able to select area on the map.

Now I will make a research and will try to implement area selection in the project for both backend and frontend.

Important Note:
We should consider which one is more suitable and which one we can use on both web and mobile

@ckertam ckertam added p:mid Address eventually backend Related to backend frontend Related to frontend labels Oct 31, 2023
@ckertam ckertam added this to the Milestone 2 milestone Oct 31, 2023
@ckertam ckertam self-assigned this Oct 31, 2023
@ckertam
Copy link
Collaborator Author

ckertam commented Oct 31, 2023

First possible selection is Google Maps API Shapes

Secondly we may try leaflet directly Leaflet

@dbaslan dbaslan changed the title Make research and try to implement area location Do research and try to implement area location Nov 1, 2023
@ckertam
Copy link
Collaborator Author

ckertam commented Nov 8, 2023

After some researches we decided to use Google Maps because it is way easier on web. And have implementation posibilities on mobile too.

@ckertam
Copy link
Collaborator Author

ckertam commented Nov 8, 2023

image

We can create something like above.

For now we can create and see stories.

Search & other implementations will be added soon 🥂

@sadikkuzu
Copy link
Member

@ckertam You quickly solve whatever is needed. Congrats, you did a great job, well done! Thank you so much ✨ 👏🏼

@ckertam
Copy link
Collaborator Author

ckertam commented Nov 11, 2023

@SWE574-Fall2023-Group1/all
Everything done! Need to test it more now.
Basically users can do belowings now.

  • Add every shape of location while creating a story.
  • Can remove them before creating the story.
  • Autocomplete still working so users can make search for locations.
  • If users click on a shape in a story the user will see the stories that has a location inside the clicked area
  • Line and point clicks return 5km radius area
  • In search page users can make search with radius & points.

Need to fix/improve

  • For now in search pages markers does not shown we need to handle it.
  • In timeline search we show the location's place. But now if the point is not point we do not show it. Need to handle it too.
  • Auto zoom & Auto centerilization not exist for now. Need to discuss where we need them. Then we can implement them

@ckertam
Copy link
Collaborator Author

ckertam commented Nov 11, 2023

We handled it in the first place. But we need to solve some bugs as I mentioned.

@ckertam ckertam closed this as completed Nov 11, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in SWE574-G1 Nov 11, 2023
@ckertam
Copy link
Collaborator Author

ckertam commented Nov 12, 2023

Close commits

7f55043
1bf18ad
d4e449f
e173e31
0511d63
6f1bfdf
966a16b
f75dd9f
8b06798
6afe008
1cfd960

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backend Related to backend frontend Related to frontend p:mid Address eventually
Projects
Status: ✅ Done
2 participants