Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make sure the updateStory endpoint converts the error message to string #247

Closed
sadikkuzu opened this issue Dec 9, 2023 · 2 comments · Fixed by #248
Closed

Make sure the updateStory endpoint converts the error message to string #247

sadikkuzu opened this issue Dec 9, 2023 · 2 comments · Fixed by #248
Assignees
@sadikkuzu
Labels
backend Related to backend
Milestone
Final Milestone

Comments

@sadikkuzu
Copy link
Member

sadikkuzu commented Dec 9, 2023 •
edited
Loading

The updateStory endpoint can return a list of error messages in some cases.

In the scope of this task, the error messages will all be in string format.
@sadikkuzu sadikkuzu added the backend Related to backend label Dec 9, 2023
@sadikkuzu sadikkuzu added this to the Final Milestone milestone Dec 9, 2023
@sadikkuzu sadikkuzu self-assigned this Dec 9, 2023
@sadikkuzu sadikkuzu moved this to 📋 Backlog in SWE574-G1 Dec 9, 2023
@sadikkuzu sadikkuzu moved this from 📋 Backlog to 🔖 ToDo in SWE574-G1 Dec 9, 2023
@sadikkuzu sadikkuzu moved this from 🔖 ToDo to 🏗 In progress in SWE574-G1 Dec 9, 2023
@sadikkuzu sadikkuzu changed the title Make sure the updateStory endpoint converts the error message to text Make sure the updateStory endpoint converts the error message to string Dec 9, 2023
sadikkuzu added a commit that referenced this issue Dec 9, 2023
@sadikkuzu
Add new validations to StoryUpdateSerializer #247
182b293
sadikkuzu added a commit that referenced this issue Dec 9, 2023
@sadikkuzu
Fix not_valid error message of UpdateStoryView #247
619a2d4
@sadikkuzu sadikkuzu mentioned this issue Dec 9, 2023
Merged
@sadikkuzu sadikkuzu linked a pull request Dec 9, 2023 that will close this issue
Feature/247 update story error message #248
Merged
@ckertam
Copy link
Collaborator

ckertam commented Dec 9, 2023

Handled by @sadikkuzu and tested by me @ckertam

@ckertam ckertam closed this as completed Dec 9, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in SWE574-G1 Dec 9, 2023
@sadikkuzu
Copy link
Member Author

Kudos to @ckertam 🎊
He indicated the actual code lines, and obviously tested the endpoint responses.
Thanks again 🙏🏼

@sadikkuzu sadikkuzu mentioned this issue Dec 10, 2023
Merged
sadikkuzu added a commit that referenced this issue Dec 10, 2023
@sadikkuzu
Merge pull request #271 from SWE574-Fall2023-Group1/dev
324d1fd 
Dev->Main #153 #215 #216 #217 #214 #143 #224 #226 #228 #143 #201 #232 #230 #223 #247 #244 #241 #237 #238 #256 #252 #257 #260 #242 #243 #113 #80 #251 #269 #267 #272
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sadikkuzu sadikkuzu

Labels
backend Related to backend
Projects
SWE574-G1
Status: ✅ Done
Milestone
Final Milestone
2 participants
@sadikkuzu @ckertam