[ORCA-163] Implement launch_workflow() and LaunchInfo dataclass
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 21 22 +1
Lines 434 626 +192
Branches 62 97 +35
==========================================
+ Hits 434 626 +192
|
thomasyu888
reviewed
Apr 28, 2023
thomasyu888
reviewed
Apr 28, 2023
thomasyu888
reviewed
Apr 28, 2023
thomasyu888
requested changes
May 1, 2023
BWMac
reviewed
May 1, 2023
|
Thank goodness for the test suite! I was able to resolve multiple merge conflicts with confidence. |
thomasyu888
approved these changes
May 1, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was initially going to port the
launch_workflow()implementation from sagetasks (source), but I decided to refactor it. Its reliance on theinit_launch_workflow_data()method is clunky. I also didn't like the large number of function parameters.To address this, I implemented the
LaunchInfodataclass. Its goal is to encapsulate the information related to launching a workflow. It essentially operates like an OpenAPI model. This results in much cleaner client code. This class can eventually be reused forget_workflow().I'm marking this PR as a draft because I would like to tackle the following subtasks:
get_compute_env()in the client classget_latest_compute_env()in the ops classlaunch_workflow()in the ops class