Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[GEN-1704] Filter out germline variants from sv files #583

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Jan 27, 2025

Purpose: This PR will be a hotfix to filter out germline variants from the sv file at the consortium release step (and subsequently the public release step since it just copies over the consortium release sv file) before we can release the germline variant validation rule.

Changes: Changes are isolated to the store_sv_files function in database_to_staging.py. Had to make it case-insensitive because I've found that SV_STATUS is in the testing pipeline's consortium release sv file while SV_Status is found in the production pipeline 's consortium release sv file.

Testing: Followed the standard validation of new features guide. The germline variants are filtered out.

@rxu17 rxu17 requested a review from a team as a code owner January 27, 2025 18:10
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM. will defer to @danlu1 for final review.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants