Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(java): Add google-java-format formatter #713

Merged
merged 7 commits into from
Sep 19, 2022
Merged

feat(java): Add google-java-format formatter #713

merged 7 commits into from
Sep 19, 2022

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 17, 2022 •
edited
Loading

Fixes #712

Changelog

  • Remove the configuration file eclipse-java-google-style.xml (deprecated).
  • Add the npm package google-java-format.
    • Provide the command google-java-format.
  • Add the VS Code extension emeraldwalk.RunOnSave.
    • Allow to run arbitrary commands when saving files in VS Code.
  • Format the Java files of the user service with the new formatter.

Preview

$ google-java-format --version
google-java-format NPM version 1.1.0 at /workspaces/challenge-registry/node_modules/google-java-format
google-java-format: Version 1.15.0

Note
The npm package v1.1.0 is installed, but is v1.15.0 actually executed?

@tschaffter tschaffter self-assigned this Sep 17, 2022
@tschaffter tschaffter changed the title feat(java): Add google-java-format formatter feat(java): Add google-java-format formatter Sep 19, 2022
@tschaffter tschaffter marked this pull request as ready for review September 19, 2022 01:43
@tschaffter tschaffter merged commit 8164a31 into Sage-Bionetworks:main Sep 19, 2022
@tschaffter tschaffter deleted the add-google-java-format branch September 19, 2022 13:17
@tschaffter tschaffter mentioned this pull request Sep 19, 2022
Closed
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add google-java-format formatter
1 participant
@tschaffter