Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

@W-12627127@ Announce wishlist change in total for screen readers #2033

Merged
merged 4 commits into from
Sep 27, 2024
Merged

@W-12627127@ Announce wishlist change in total for screen readers #2033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba0232d
announce change in price for screen readers
bfeister Sep 27, 2024
e085526
Merge branch 'develop' into feature/W-12627127-wishlist-aria
bfeister Sep 27, 2024
674cc74
add to CHANGELOG
bfeister Sep 27, 2024
6eaf8f7
Merge branch 'feature/W-12627127-wishlist-aria' of github.com:Salesfo…
bfeister Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/template-retail-react-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## v4.1.0-dev (Aug 8, 2024)

- Add useXForwardedHost (default to false) flag to allow the use of x-forwarded-host header value in building links [#2018](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2018)
- Announce wishlist change in total for screen readers [#2033](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2033)

### Performance Improvements
- Remove ocapi session-bridging on phased launches [#2011](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2011)
Expand Down
1 change: 1 addition & 0 deletions packages/template-retail-react-app/app/components/display-price/current-price.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const CurrentPrice = ({labelForA11y, price, as, isRange = false, currency, ...ex
<Text
as={as}
{...extraProps}
aria-live={'polite'}
aria-label={intl.formatMessage(msg.ariaLabelCurrentPriceWithRange, {
currentPrice: currentPriceText
})}
Expand Down
Loading