fix(prefabs): fix disabling prefabs with non-alive components (follow-up #1577) #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prefabs When a prefab type was added as a component of itself and subsequently disabled, the enabling/disabling code entered an infinite recursion. This commit introduces a check to detect self-references in disabled prefabs.
Indra-db
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1577 should be merged first as it's based on it. Ran into a new issue where toggle-able components caused
ecs_is_aliveasserts when disabling a prefab. this also happens with pairs of (Enum, EnumVariant), etc