Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MToonにて、RimLightの計算時にNaNが紛れ込む問題を修正 #117

Merged
merged 1 commit into from
Nov 2, 2022
Merged

MToonにて、RimLightの計算時にNaNが紛れ込む問題を修正 #117

merged 1 commit into from
Nov 2, 2022
+1 −1

Conversation

notargs
Copy link
Contributor

@notargs notargs commented Nov 2, 2022

MToonにて、RimLightの計算時にNaNが紛れ込む問題を修正します

ousttrue
ousttrue approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Santarh Santarh merged commit 01b8b31 into Santarh:master Nov 2, 2022
ousttrue
ousttrue approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MToon-1.0 と同様

@Santarh Santarh mentioned this pull request Nov 2, 2022
Merged
Sonic853 added a commit to Sonic853/MToon2Side that referenced this pull request Nov 24, 2022
@Sonic853
fix: Fix from Santarh/MToon#117
fcb7493
@0b5vr
Copy link
Contributor

0b5vr commented Feb 24, 2023

vrm-c/vrm-specification#418 に相当する変更ですね。

three-vrm側は未着手？要調査

https://github.com/pixiv/three-vrm/blob/v1.0.8/packages/three-vrm-materials-mtoon/src/shaders/mtoon.frag#L677

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notargs @0b5vr @ousttrue @Santarh