Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rename parameter up_angle to up_theta for consistency and check conversion from old models #471

Closed
pkienzle opened this issue Aug 24, 2021 · 2 comments · Fixed by #490
Closed
Milestone

Comments

@pkienzle
Copy link
Contributor

Orientation angles are θ, φ, ψ most everywhere but magnetic orientation uses up_angle and up_phi for historical reasons. Rename up_angle to up_theta and make sure that older models get converted.

Verify that θ, φ use the same orientation system as the particle axis, both for applied field and for orientation of the magnetism within the particle.

Also, make sure that models saved without up_phi are loaded correctly in versions that support arbitrary applied field.

@dehoni
Copy link
Contributor

dehoni commented Sep 2, 2021

In realspace.py, the rotation matrixes and the definition of orientation coordinates pol2rec are consistent with the coordinates for the polarisation vector p_hat in the function magnetic_sld .
I would need to guess the origin of the expressions for view and jitter matrices in kernel_iq.c, such that I can not state if they are in line. Similarly, the dedicated magnetic models in the model market place need an extra look, while doing the refactoring mentioned in ticket #450.

@pkienzle
Copy link
Contributor Author

Related: sasview generic scattering calculator SasView/sasview#1971

@dehoni dehoni linked a pull request Nov 23, 2021 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants