Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Call magnetic angles up_theta #1971

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

dehoni
Copy link
Contributor

@dehoni dehoni commented Nov 22, 2021

Orientation angles are θ, φ, ψ but magnetic orientation uses up_angle and up_phi. Rename up_angle to up_theta for consistency

Verify that θ, φ use the same orientation system as the particle axis, both for applied field and for orientation of the magnetism within the particle.

@dehoni dehoni self-assigned this Nov 22, 2021
@dehoni dehoni added the Scattering Calculator Tool Concerns scattering calculator label Nov 22, 2021
@dehoni dehoni linked an issue Nov 22, 2021 that may be closed by this pull request
@wpotrzebowski wpotrzebowski added the Discuss At The Call Issues to be discussed at the fortnightly call label Nov 22, 2021
@pkienzle
Copy link
Contributor

Is there a "save perspective" for the generic scattering calculator, and does it store up_angle? You may need to add code to update the perspective parameters on reload.

@dehoni
Copy link
Contributor Author

dehoni commented Nov 22, 2021

Is there a "save perspective" for the generic scattering calculator, and does it store up_angle? You may need to add code to update the perspective parameters on reload.

The Scattering Calculator can only save nuclear and magnetc SLD data in the sample coordinate frame with no information on environment coordinates that include the angles up_theta and up_phi setting the polarisation vector. The user will provide these parameters as input before computation of the scattering pattern.

@dehoni dehoni added this to the SasView 5.1.0 milestone Jan 18, 2022
@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Feb 15, 2022
@wpotrzebowski wpotrzebowski merged commit 31e588f into main Mar 29, 2022
@dehoni dehoni deleted the ticket-1908-magnetic-angle branch August 16, 2022 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Scattering Calculator Tool Concerns scattering calculator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use up_theta instead of up_angle as magnetic parameter name
3 participants