Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Plot legend enable/disable does not persist between plot draws (e.g. fit runs) #2215

Closed
pbeaucage opened this issue Sep 23, 2022 · 0 comments · Fixed by #2266
Closed

Plot legend enable/disable does not persist between plot draws (e.g. fit runs) #2215

pbeaucage opened this issue Sep 23, 2022 · 0 comments · Fixed by #2266
Assignees

Comments

@pbeaucage
Copy link
Contributor

Describe the bug
#1523 re-added a context menu toggle for visibility of the legend in a plot; however, that toggle just uses matplotlib methods to enable/disable the legend rather than using the internal Plotter class variables, which means that the visibility setting does not persist between re-draws of the plot during, for example, runs of a fit.

This tiles with other bugs such as #1337 on Mac and #2012 more generally to make 5.x versions often unusable with long filenames on Macs, since the legend obstructs the plot and one cannot turn it off without tediously clicking it off every time a fit variable is changed.

To Reproduce
Steps to reproduce the behavior:

  1. Generate a plot from e.g. the fitting perspective
  2. Toggle legend off using context menu
  3. Perform an action (e.g. run a fit) that re-draws the plot.
  4. Legend appearance will revert to on regardless of prior setting.

Expected behavior
Legend appearance/disappearance should follow previous plot interactions.

SasView version (please complete the following information):

  • Version: 5.0.5

Operating system (please complete the following information):

  • OS: Mac 12.5.1
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant