Plot legend visibility toggle needs to be restored

[butlerpd]

@smk78 Notes that: Modify Plot Property functionality that allows the user to change, for example, axis labels, needs to be brought back into 5x. This related to but different from issue #1414 in that both were plotting functionality that were lost in the move from 4 to 5 and need to be at least restored (though they could also use improvement).

NOTE: the DREAM plots do contain the toolbar with all manner of plot control options. I guess these are being served by bumps directly instead of SasView?.

[rozyczko]

I have it on my list and am currently testing but this won't be merged into 5.0.2. Let's have it in 5.0.3/5.1 as it is "new" (in ver 5)

[rozyczko]

Re: DREAM - yes, these charts are served directly by BUMPS.

[smk78]

4.x also had the ability to toggle the legend off/on. This also needs implementing in 5.x.

And there have been complaints from users that the font size used in the legend is quite large, meaning the legend can take up a lot of real estate if the dataset names are long, and/or if plotting several datasets/theories. Would it be possible to provide some control over this?

Update from user:

On Linux, I don't have the giant-legend problem. It seems to be MacOS.
But I tried what you wrote (on Linux).
I right-clicked the plot, went to "Modify Plot Property" and just deleted the text in the QLineEdit right of "Legend label".
The legend stayed on and the text didn't change.
Again, I right clicked into the plot and went to "Modify Plot Property". The QLineEdit right of "Legend label" was still as empty as I left it the first time.
The legend, however, stays as it is.
On Mac, the behaviour is the same + that the legend is gigantic.
If you just modify the text in the QLineEdit instead of deleting it completely, the modifications are shown in the plot window at least until you recalculate the model, for example changing the "scake" from "scale = 1.0" to "scale = 2.0".

[rozyczko]

Legend size on OSX is a separate, large issue. Not sure if this has been addressed?

[smk78]

Ahh, yes: #1337

[rozyczko]

Original request in this issue has been addressed by adding the MPL toolbar toggle.
This means the only thing to do here is to toggle legend on/off.
I will rename the issue and address the problem

[rozyczko]

Added toggle legend context menu item for 1D plots (quick and standard).