Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

numpy 1.24 (in)compatibility #2416

Open
llimeht opened this issue Jan 9, 2023 · 1 comment
Open

numpy 1.24 (in)compatibility #2416

llimeht opened this issue Jan 9, 2023 · 1 comment
Labels
Blocked Issues that are blocked by something Infrastructure GitHub, project structure, community etc Spring Cleaning 2024

Comments

@llimeht
Copy link
Contributor

llimeht commented Jan 9, 2023

numpy 1.24 has now been released and so we will at some stage need compatibility with it. So far, I've only spotted 4 tiny things that need fixing, related to removal of deprecated functions. In particular, numpy 1.24 has finally removed the deprecated np.float definition. This should either be replaced by float if machine-variation is permitted (i.e. 32 bit or 64 bit depending on the architecture), or np.float64 if a specific size is needed.

See: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

This is fortunately quite easy to fix in a backwards compatible way:

https://sources.debian.org/src/sasview/sid/debian/patches/numpy-1.24.patch/

The failures in p_invertor.py are caught by the test suite; I grepped the source looking for other instances which turned up the instance in GuiUtils.py.

SasView version (please complete the following information):

  • Version: 5.0.5 and main (and any other release)

Operating system (please complete the following information):

  • OS: all (tested on linux)
@lucas-wilkins
Copy link
Contributor

@llimeht what's the status of this, is it waiting on changes to P(r) which is waiting on the pull request that has been sitting around for ages?

Adding blocked label for now.

@lucas-wilkins lucas-wilkins added the Blocked Issues that are blocked by something label Mar 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Blocked Issues that are blocked by something Infrastructure GitHub, project structure, community etc Spring Cleaning 2024
Projects
None yet
Development

No branches or pull requests

3 participants