Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added 3.11, removed 3.8 #2582

Merged
merged 10 commits into from
Sep 17, 2023
Merged

Added 3.11, removed 3.8 #2582

merged 10 commits into from
Sep 17, 2023

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Aug 8, 2023

Description

Removed 3.8 and added 3.10, 3.11 to build/test matrix
Removed pinned versioning which caused issues with 3.11

Local win10 dev build and installer

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)

@llimeht
Copy link
Contributor

llimeht commented Aug 8, 2023

Would np.float64 be better to be explicit about the precision? Probably makes no real difference unless someone is marshalling this through C somewhere.
https://sources.debian.org/src/sasview/5.0.5-5/debian/patches/numpy-1.24.patch/

This work should also close #2416.

@rozyczko
Copy link
Member Author

rozyczko commented Aug 8, 2023

Would np.float64 be better to be explicit about the precision? Probably makes no real difference unless someone is marshalling this through C somewhere. https://sources.debian.org/src/sasview/5.0.5-5/debian/patches/numpy-1.24.patch/

This work should also close #2416.

Shouldn't make a difference, since the built-in float is dp anyway on non-32 bit arch.
It might be useful to have it spelled out explicitly, maybe, so let's do it then.

@wpotrzebowski
Copy link
Contributor

I was curious if OSX installer works on 3.11 and it seems to work fine!

@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Aug 14, 2023
@butlerpd
Copy link
Member

Not sure we need all 3 python versions. Maybe focus on 3.11 and try to make sure everything works there. Needs lots of testing. Aim to merge prior to code camp to ensure fulsome testing.

@butlerpd butlerpd removed the Discuss At The Call Issues to be discussed at the fortnightly call label Aug 15, 2023
@rozyczko
Copy link
Member Author

Not sure we need all 3 python versions. Maybe focus on 3.11 and try to make sure everything works there. Needs lots of testing. Aim to merge prior to code camp to ensure fulsome testing.

Good catch. We only need one python version for the release (3.11) but we want testing to be done on all supported versions (3.8, 3.9, 3.10, 3.11)

@wpotrzebowski wpotrzebowski added the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 12, 2023
@wpotrzebowski
Copy link
Contributor

@rozyczko to resolve the conflict and then we should merge it.

@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 12, 2023
@wpotrzebowski
Copy link
Contributor

wpotrzebowski commented Sep 16, 2023

The installer starts on Mac, however, it crashes whenever I try to access any folder.
Debugging in the local branch gives an error

Qt has caught an exception thrown from an event handler. Throwing exceptions from an event handler is not supported in Qt. You must not let any exception whatsoever propagate through Qt code. Fatal Python error: PyGILState_Release: thread state 0x1026663a8 must be current when releasing Python runtime state: initialized

@wpotrzebowski wpotrzebowski marked this pull request as ready for review September 17, 2023 14:23
@wpotrzebowski wpotrzebowski merged commit 90e45b7 into main Sep 17, 2023
@wpotrzebowski wpotrzebowski deleted the ci_updated_python branch September 17, 2023 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants