Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #2334 two issues related to invariant perspective were identified. The firts issue with read only fields for Qmin and Qmax should be fixed now. However the other problem is more deconvoluted as it is related to the fact that we calculate invariant based on
(scale * data) - background
, which requires correct setting for scale and background. As it turned out for apoferitin example the values coming from fitting may be over/underestimated and therefore Q* may become negative. Warning has been added to the code suggesting checking backround and scale value. In the future we may consider more inteligent guidance.I've checked documentation. It seems to be consitent but maybe we should add note about scale/background issue?
Fixes #2334
How Has This Been Tested?
Review Checklist (please remove items if they don't apply):