Avoid parenting mess by calling the widget directly #2559
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When counting instances of plots, one needs to be careful with QtWidget parentage being updated.
The existing Manager->Plotter->PlotterWidget chain was working with Qt5 (and from what I remember was necessary to achieve correct MDI space location) but started failing with Qt6.
Getting rid of
Plotter
and instantiatingPlotterWidget
directly seems to be safer.Fixes #2527
How Has This Been Tested?
local testing on win10
Review Checklist (please remove items if they don't apply):