Improved log explorer behaviour #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the slot is defined
|
Link issue (I'll find it later) |
I had it set to warning for debugging purposes
|
I've got an alternate approach to this which uses the record and the logging formatter instead of trying to parse the information out of the error message. PR #2639 will merge my changes into this PR |
|
@rprospero's version works well and improves the original way of log message syntax highlighting. |
wpotrzebowski
approved these changes
Sep 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behaviour of the log explorer has been modified.
It is now disabled by default.
One can explicitly enable it by going to the menus (
View/Show Log Explorer).Alternatively, it will be shown immediately on any error.
Also, added a simple colour switch on WARNING/ERROR messages in the log window.
Now, all errors show in red and warnings in orange-ish.
INFO and DEBUG are still in black.
Review Checklist (please remove items if they don't apply):