added missing import statement for logging to enable error messages i… #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a pop up window when slit width is set larger than slit length
|
This PR is currently pointing towards main but do we also want to have this fix in release_6.0.0? |
|
Agreed this should point to 6.0.0. On another note - should we keep this open to use in the training on reviewing PR? |
lucas-wilkins
deleted the
2708-missing-import-statement-for-logging-in-smearingwidget
branch
caitwolf
restored the
2708-missing-import-statement-for-logging-in-smearingwidget
branch
|
Restoring this branch for now so we can include this in 6.0.0 |
|
@butlerpd should we merge this change with the 6.0.0 release branch? This had gotten merged to main during contributor camp and I hadn't circled back to our above discussion to merge it in both |
7 tasks
caitwolf
deleted the
2708-missing-import-statement-for-logging-in-smearingwidget
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a pop up window when slit width is set larger than slit length
Description
This PR returns the missing import statement for logging in the smearing widget.
Fixes #2708
How Has This Been Tested?
Simulated data using the sphere model in the GUI with slit smearing at the following three conditions:
Conditions 2 and 3 should result in an error message being presented in a pop-up window that explains the proper usage of the length and width terms for slit smearing. "CRITICAL" messages should also appear in the log explorer. Condition 1 should run normally and simulate the slit-smeared data.
Review Checklist (please remove items if they don't apply):