Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't initialize the base class twice #2824

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

rozyczko
Copy link
Member

Description

Base QWidget class was being initialized twice leading to the Generic Scattering Calculator throwing on Draw.

Fixes #2818

How Has This Been Tested?

Local win10 tests

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@lucas-wilkins lucas-wilkins added the SasView 6.0.0 Required for 6.0.0 release label Mar 15, 2024
@wpotrzebowski
Copy link
Contributor

Tested on Mac and generally it seems to work fine, however, I also had a few unexpected crashes... At the moment I cannot find a reproducible path. (It may also be unrelated to this PR).

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the error reported. clicking draw no longer throws a traceback error saying that you cannot initialize the widget twice.

Now that we can in fact see the drawing rendering there is some flakiness with those drawing randomly disappearing and even once crashing while playing with the 3D graphics. That however is clearly a different and deeper issue which has not been spotted because heretofore one could not even get the drawing up.

We should try to document the flakiness better and create an issue(s) that need addressing

@butlerpd butlerpd merged commit a458633 into release_6.0.0 Mar 22, 2024
37 checks passed
@butlerpd butlerpd deleted the 2818-draw-throws-gsc branch March 22, 2024 17:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants