Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2855: Fix model save error #2864

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Apr 26, 2024

Description

A flag was added to the TabbedModelEditor to differentiate documentation edits from model edits. This stops the editor attempting to generate the documentation when saving a model.

In the future, the two editor types should be different classes (#2863).

Fixes #2855

How Has This Been Tested?

Tested

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

…s to be treated differently than model edits.
@krzywon krzywon requested a review from juliuskarliczek April 26, 2024 19:30
@butlerpd butlerpd added the SasView 6.0.0 Required for 6.0.0 release label Apr 29, 2024
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on windows also. It basically was no allowing us to edit plugin models. However, it does now mean that once a plugin model has had its documentation generated, it is impossible to regenerate if I make corrections to my model.

I suggest that is a separate bug which also opens its own can of worms: what about built-in models? On the other hand it is suggesting yet again that we separate the "save" from the regeneration which would also be helpful when editing documentation.

@butlerpd butlerpd merged commit 199dbfa into release_6.0.0 May 3, 2024
29 checks passed
@butlerpd butlerpd deleted the 2855-save-cusotm-model-error branch May 3, 2024 23:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants