Solve an issue with MP container checkouts #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffin-Sullivan
approved these changes
Oct 13, 2022
|
Breaking for me with |
JacobCallahan
force-pushed
the
h8pickles
branch
from
d24e076 to
02b3e1e
Compare
adarshdubey-star
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Thanks, @JacobCallahan for the prompt fix, LGTM tested locally as well!
An issue was identified where the _cont_inst property was being stripped from the modified Host class during MP checkouts. The solution I opted for was to recreate the missing container instance post-pickle. This removed the entire need for the _cont_inst property. I then took this further with additional pickle protection.
JacobCallahan
force-pushed
the
h8pickles
branch
from
02b3e1e to
a55d243
Compare
Also, update the install to include docker deps for unit tests.
JacobCallahan
force-pushed
the
h8pickles
branch
from
0b5dc47 to
baf0084
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was identified where the _cont_inst property was being stripped from the modified Host class during MP checkouts.
The solution I opted for was to recreate the missing container instance post-pickle. This removed the entire need for the _cont_inst property.