Better handle situations where the parent directory doesn't exist during sftp #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing sftp This change adds some additional logic to not only handle when parent directories don't exist, but also constructs the destination path when only a directory is given Fixes SatelliteQE#169
Griffin-Sullivan
approved these changes
Dec 9, 2022
ogajduse
approved these changes
Dec 13, 2022
|
@ogajduse performed some extensive testing in CI running on py3.11 and the results look great |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some additional logic to not only handle when parent directories don't exist, but also constructs the destination path when only a directory is given
Fixes #169
Both affected functional tests pass