Logging improvements & fixes #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffin-Sullivan
approved these changes
Jan 30, 2023
JacobCallahan
requested changes
Jan 30, 2023
broker/settings.py
Outdated
| Validator("LOGGING.LEVEL", is_in=["error", "warning", "info", "debug", "trace", "silent"], default="info"), | ||
| Validator("LOGGING.FILE_LEVEL", is_in=["error", "warning", "info", "debug", "trace", "silent"], default="debug"), | ||
| Validator( | ||
| "LOGGING.LEVEL", |
There was a problem hiding this comment.
Is this the new version?
Suggested change
| "LOGGING.LEVEL", | |
| "LOGGING.CONSOLE_LEVEL", |
There was a problem hiding this comment.
🤦♂️ oh yeah, I forgot that one.
Fixed by f4e3aef.
* formatted logging related code using black
* removed deprecated logzero.setup_default_logger
* broken down into logzero.formatter, logzero.loglevel and logzero.logfile
* fixed broken logging in ipython console with %autoreload 2 turned on
* _old_factory is None by default and is set to
`broker_record_factory` only if _old_factory was not set to
`broker_record_factory` yet.
ogajduse
force-pushed
the
fix/logging/old_factory
branch
from
a14db34 to
f4e3aef
Compare
|
some test results: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broker_record_factoryonly if _old_factory was not set tobroker_record_factoryyet.