Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use host facts when syncing inventory from AAP #261

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

tpapaioa
Copy link
Collaborator

@tpapaioa tpapaioa commented Jan 30, 2024

Get _broker_args from host's ansible_facts, if present, instead of from the job / workflow job attributes.

@tpapaioa tpapaioa force-pushed the use_host_facts branch 2 times, most recently from 691e1e2 to 7ba1477 Compare January 30, 2024 19:45
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. Also, please run pre-commit before pushing back up

Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are passing and the changes proposed look good. Aside from a new merge conflict from #262 is this ready to merge?

@tpapaioa tpapaioa marked this pull request as ready for review January 31, 2024 19:09
@JacobCallahan JacobCallahan merged commit f84c820 into SatelliteQE:master Jan 31, 2024
4 checks passed
@tpapaioa tpapaioa deleted the use_host_facts branch January 31, 2024 20:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants