Update the way we're getting a container's hostname

[JacobCallahan]

Previously, if a user set a hostname on a container, Broker wouldn't recognize that. This is because we just looked up the container's id. When a hostname isn't set at runtime, this is perfectly fine. However, when a user does set a hostname, this breaks what would be expected.

With this change, we have a more reliable way to solve both cases.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

broker/providers/container.py:25

• Ensure that the new method of fetching the hostname from container attributes is covered by tests.

"hostname": container_inst.attrs["Config"].get("Hostname"),

broker/providers/container.py:211

• Ensure that the new method of fetching the hostname from container attributes is covered by tests.

hostname = cont_inst.attrs["Config"].get("Hostname")

[aadhikar]

LGTM!

[JacobCallahan]

Tests currently failing due to: containers/podman-py#514, which @jyejare has already resolved. Hopefully we will get a new build of podman-py soon. However, I won't block this PR until then.

Manual testing of the changes show it working both for @aadhikar and myself.

❯ broker checkout --container-host localhost/ubi9:latest --hostname second.test.hostname
[INFO 250219 09:52:39] Using provider Container to checkout
[INFO 250219 09:52:39] Host: second.test.hostname

and in the inventory

4:
  name: jake_812af936
  _broker_provider_instance: podman_ipv4
  type: host
  hostname: second.test.hostname
  _broker_provider: Container
  _broker_args:
    container_host: localhost/ubi9:latest
    hostname: second.test.hostname
  exposed_ports: {

and now on the container itself

[root@infra-podman-ipv4 ~]# podman exec -it jake_812af936 /bin/bash
[root@second ~]# hostname
second.test.hostname

[jyejare]

@JacobCallahan @aadhikar The podman-py new version is released with fix. I have rerun all the checks for this PR.