Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pull mode rex survives leapp upgrade #16869

Merged
merged 1 commit into from
Feb 17, 2025
Merged

pull mode rex survives leapp upgrade #16869

merged 1 commit into from
Feb 17, 2025

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Nov 5, 2024

Problem Statement

check that pull-rex mode setup survives leapp upgrade, preparation for SAT-28315, SAT-27476

Solution

Related Issues

@pondrejk pondrejk added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 5, 2024
@pondrejk pondrejk self-assigned this Nov 5, 2024
@pondrejk pondrejk requested a review from a team as a code owner November 5, 2024 14:58
@pondrejk
Copy link
Contributor Author

pondrejk commented Nov 5, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@pondrejk pondrejk changed the title leap-rex wip pull mode rex survives leapp upgrade Nov 6, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9293
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 failed, 2 deselected, 21 warnings in 3061.21s (0:51:01) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 6, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

1 similar comment
@pondrejk
Copy link
Contributor Author

pondrejk commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9296
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 failed, 2 deselected, 21 warnings in 3141.60s (0:52:21) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9297
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 failed, 2 deselected, 21 warnings in 3490.95s (0:58:10) ===========

@pondrejk
Copy link
Contributor Author

seems like the prt failure might point to a different bug, investigation is going

@pondrejk pondrejk marked this pull request as draft November 12, 2024 13:05
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9381
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 failed, 2 deselected, 19 warnings in 3173.21s (0:52:53) ===========

@pondrejk
Copy link
Contributor Author

nts: SAT-29761 found by this

@github-actions GitHub Actions
Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Jan 13, 2025
@pondrejk pondrejk removed the Stale Stale issue or Pull Request label Jan 16, 2025
@pondrejk pondrejk added the Stream Introduced in or relating directly to Satellite Stream/Master label Jan 31, 2025
@pondrejk pondrejk marked this pull request as ready for review January 31, 2025 13:45
@pondrejk pondrejk requested a review from a team as a code owner January 31, 2025 13:46
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10027
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 passed, 2 deselected, 23 warnings in 4939.19s (1:22:19) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 31, 2025
Gauravtalreja1
Gauravtalreja1 reviewed Feb 14, 2025
View reviewed changes
tests/foreman/cli/test_leapp_client.py
invocation_command = module_target_sat.cli_factory.job_invocation_with_credentials(
{
'job-template': 'Run Command - Script Default',
'inputs': "command=ls",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM, I wonder why the REX is needed to run the ls command in the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just an additional check to be sure, even if the service is up on the client, there could potentially be some problem with the actual execution

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 17, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10203
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : =========== 2 deselected, 14 warnings, 1 error in 900.83s (0:15:00) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 17, 2025
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10206
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_ygdrassil_client_after_leapp_upgrade --external-logging
Test Result : ========== 1 passed, 2 deselected, 23 warnings in 4582.31s (1:16:22) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 17, 2025
@pondrejk pondrejk merged commit eec1583 into SatelliteQE:master Feb 17, 2025
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@shweta83 shweta83 shweta83 left review comments

Assignees

@pondrejk pondrejk

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @Gauravtalreja1 @shweta83