Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test checking needs publish banner on cv index page #17154

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

sambible
Copy link
Contributor

Problem Statement

Test supporting this Customer Issue: https://issues.redhat.com/browse/SAT-28271

Solution

Adds a test validating this issue+

Related Issues

Requires Airgun PR: SatelliteQE/airgun#1653

@sambible sambible requested a review from a team December 12, 2024 06:41
@sambible sambible self-assigned this Dec 12, 2024
@LadislavVasina1
Copy link
Contributor

@sambible To which branches do you want this PR to be merged?

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks good, one question and PRT pending.

Comment on lines 355 to 359
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the logic be the opposite? The "no changes" warning displayed after publish, not before?

Suggested change
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
result = session.contentview_new.check_publish_banner(cv.name)
assert not result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert result2

@vsedmik
Copy link
Contributor

vsedmik commented Dec 19, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_cv_publish_warning
airgun: 1653

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9674
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_cv_publish_warning --external-logging
Test Result : =========== 1 failed, 7 deselected, 17 warnings in 649.18s (0:10:49) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 19, 2024
@sambible sambible added the Stream Introduced in or relating directly to Satellite Stream/Master label Jan 15, 2025
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_cv_publish_warning
airgun: 1653

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9887
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_cv_publish_warning --external-logging
Test Result : =========== 1 passed, 7 deselected, 17 warnings in 754.04s (0:12:34) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 15, 2025
@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 16, 2025
@jameerpathan111 jameerpathan111 merged commit 68c7588 into SatelliteQE:master Jan 17, 2025
10 of 13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants