Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix rails cache store test in installer #17330

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rmynar
Copy link
Contributor

@rmynar rmynar commented Jan 14, 2025

Package foreman-redis is now installed in earlier stage as a requirement, not by satellite-installer. It is installed even if different cache provider is set, so we have to remove the test step.

@rmynar rmynar added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jan 14, 2025
@rmynar rmynar self-assigned this Jan 14, 2025
@rmynar rmynar requested a review from a team as a code owner January 14, 2025 11:47
@rmynar
Copy link
Contributor Author

rmynar commented Jan 14, 2025

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k test_foreman_rails_cache_store

@@ -460,7 +460,6 @@ def test_foreman_rails_cache_store(sat_non_default_install):
:BZ: 2063717, 2165092, 2244370
"""
# Verify foreman-rails-cache-store option works
Copy link
Contributor

@jameerpathan111 jameerpathan111 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmynar, can you update the test steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9851
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/installer/test_installer.py -k test_foreman_rails_cache_store --external-logging
Test Result : ========== 1 passed, 19 deselected, 38 warnings in 2047.62s (0:34:07) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 14, 2025
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 14, 2025
@jameerpathan111 jameerpathan111 merged commit b982550 into SatelliteQE:master Jan 14, 2025
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants