Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Verify the content type of flatpak manifests #17537

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 6, 2025

Problem Statement

New content_type field has been added to the container manifests and container manifests list so that users can differentiate between flatpaks and other container images. We should check the field is set properly for the flatpak manifests.

Solution

This PR extends test_sync_consume_flatpak_repo_via_library with this assertion.
Apart from that it also leverages the function_flatpak_remote fixture.

Related Issues

https://issues.redhat.com/browse/SAT-21691

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k 'test_scan_flatpak_remote or test_flatpak_pulpcore_endpoint or test_sync_consume_flatpak_repo_via_library'
Katello:
  katello: 11300

- test manifest and manifest_list content type
- leverage the flatpak_remote fixture
@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 6, 2025
@vsedmik vsedmik self-assigned this Feb 6, 2025
@vsedmik vsedmik requested review from a team as code owners February 6, 2025 16:57
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 6, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k 'test_scan_flatpak_remote or test_flatpak_pulpcore_endpoint or test_sync_consume_flatpak_repo_via_library'
Katello:
  katello: 11300

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10113
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_flatpak.py -k test_scan_flatpak_remote or test_flatpak_pulpcore_endpoint or test_sync_consume_flatpak_repo_via_library --external-logging
Test Result : ========== 4 passed, 1 deselected, 133 warnings in 1935.23s (0:32:15) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 6, 2025
@ogajduse ogajduse merged commit 51dce3f into SatelliteQE:master Feb 12, 2025
12 checks passed
@vsedmik vsedmik deleted the check-flatpak-image-flags branch February 12, 2025 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants