Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix provisioning tests #17571

Conversation

shubhamsg199
Copy link
Contributor

Problem Statement

Provisioning tests are failing with AttributeError: 'ContentHost' object has no attribute '_broker_facts'. Did you mean: '_broker_args'?

Solution

Fix the test

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Feb 12, 2025
@shubhamsg199 shubhamsg199 self-assigned this Feb 12, 2025
@shubhamsg199 shubhamsg199 requested review from a team as code owners February 12, 2025 07:22
@shweta83
Copy link
Contributor

@shubhamsg199 The changes of broker_facts has been introduced recently and @Gauravtalreja1 has added this change in https://github.com/SatelliteQE/robottelo/pull/17492/files. Do you know why host created doesn't have broker_facts param?

Signed-off-by: Shubham Ganar <sganar@redhat.com>
@shubhamsg199 shubhamsg199 force-pushed the fix_provisioning_tests_broker_error branch from e653785 to 9f73fea Compare February 12, 2025 07:36
@shubhamsg199
Copy link
Contributor Author

shubhamsg199 commented Feb 12, 2025

@shubhamsg199 The changes of broker_facts has been introduced recently and @Gauravtalreja1 has added this change in https://github.com/SatelliteQE/robottelo/pull/17492/files. Do you know why host created doesn't have broker_facts param?

@shweta83 Yes, but the provisioning_host fixture returns a Contenthost object which doesn't contain _broker_facts or _broker_args . Maybe because of the broker update it behaves different now

@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. and removed Do Not Merge labels Feb 12, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 05f5758 into SatelliteQE:master Feb 12, 2025
12 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Shubham Ganar <sganar@redhat.com>
(cherry picked from commit 05f5758)
Gauravtalreja1 pushed a commit that referenced this pull request Feb 12, 2025
Fix provisioning tests (#17571)

Signed-off-by: Shubham Ganar <sganar@redhat.com>
(cherry picked from commit 05f5758)

Co-authored-by: Shubham Ganar <67952129+shubhamsg199@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants