Add changeAdminStatus #658
Conversation
|
could you do git remote add upstream https://github.com/Schmavery/facebook-chat-api
git fetch upstream
git rebase upstream/master
git push -fit would get rid of all these duplicated commits in every pull request :/ |
AstroCB
force-pushed
the
master
branch
4 times, most recently
from
e4db993 to
5fc94b4
Compare
AstroCB
force-pushed
the
master
branch
4 times, most recently
from
32b4acc to
d88f21f
Compare
|
Good call – thanks @ravkr |
src/changeAdminStatus.js
Outdated
| utils.getType(threadID) === "Function" || | ||
| utils.getType(threadID) === "AsyncFunction") | ||
| ) { | ||
| throw { error: "please pass makeAdmin and threadID as the second/third arguments." }; |
There was a problem hiding this comment.
If these are required fields, we can probably just check their types rather than checking if they're not a callback?
There was a problem hiding this comment.
Yep, another holdover from the basis file I used.
|
Yes, both PR are doing the same thing I'm not saying that one PR is better that the other, but I just wanted to show what I've made |
|
@AstroCB did you find these fields are required/used by the browser when you looked or do you think we can just remove them? |
|
Nope, they’re just holdovers from another file that I used as the basis for this – should be good to remove. I can take them out and clean up the param checks, but it might just be easier to merge @ravkr’s version. |
|
@ravkr 's change has no docs though 😛 |
|
You can review mine PR |
|
Made the discussed changes last night and forgot to publish – they're up now, but either way works for me. |
|
@Schmavery what's the decision? |
Adds a
changeAdminStatusfunction to allow the API to alter the admin status of users in group chats (naming suggestions welcome).re: #624