Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

๐Ÿ”€ :: [#412] ์ž๋™ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„ #413

Merged
merged 1 commit into from
Aug 19, 2024
Merged

๐Ÿ”€ :: [#412] ์ž๋™ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„ #413

merged 1 commit into from
Aug 19, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Aug 19, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์ž๋™ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ์ด ์—†์–ด์„œ ์•ฑ์„ ํ‚ฌ ๋•Œ๋งˆ๋‹ค ๋กœ๊ทธ์ธ์„ ๋‹ค์‹œ ํ•ด์•ผํ•˜๋Š” ๋ถˆํŽธํ•จ์ด ์žˆ์—ˆ์–ด์š”.
Resolves: #412

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋กœ๊ทธ์ธ ํŽ˜์ด์ง€๊ฐ€ ๋กœ๋“œ ๋˜๋ฉด์„œ onAppearํ•จ์ˆ˜๋ฅผ ํ†ตํ•ด ํ† ํฐ ์žฌ๋ฐœ๊ธ‰ ๊ธฐ๋Šฅ์„ ์ง„ํ–‰ํ•˜๊ณ  ํ† ํฐ ์žฌ๋ฐœ๊ธ‰์ด ์„ฑ๊ณตํ–ˆ์„ ๋•Œ ์ž๋™์œผ๋กœ ๋กœ๊ทธ์ธ์„ ์ง„ํ–‰ํ•˜๋„๋ก ๊ตฌ์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

@uuuunseo uuuunseo added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โšก๏ธperformance ์„ฑ๋Šฅ ๊ฐœ์„  โœ… Test Test๊ด€๋ จ์‚ฌํ•ญ โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Aug 19, 2024
@uuuunseo uuuunseo self-assigned this Aug 19, 2024
@uuuunseo uuuunseo linked an issue Aug 19, 2024 that may be closed by this pull request
์ž๋™๋กœ๊ทธ์ธ ๊ตฌํ˜„ #412
Closed
@uuuunseo uuuunseo merged commit 4c71447 into master Aug 19, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 412-auto-login branch August 19, 2024 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GangMinSu GangMinSu GangMinSu approved these changes

Assignees

@uuuunseo uuuunseo

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ โšก๏ธperformance ์„ฑ๋Šฅ ๊ฐœ์„  โœ… Test Test๊ด€๋ จ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

์ž๋™๋กœ๊ทธ์ธ ๊ตฌํ˜„
2 participants
@uuuunseo @GangMinSu