Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated netlist_reader.py to use the natsort library for sorting. #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BillyPocketNC
Copy link

This may make installing for kicad harder.

I found the natsort library in pip, and changed the file to use it.
Would you like to include this change? I know it could make installing this project more difficult.

This is related to issue #156

This may make installing for kicad harder.
@set-soft
Copy link
Contributor

But this should be controlled by an option!

@BillyPocketNC
Copy link
Author

Thanks @set-soft. I will put this in my todo list.

@SchrodingersGat
Copy link
Owner

@BillyPocketNC long time to review on this one, sorry.

If you want to see this merged, please add the library requirement to setup.py (under install_requires section)

Also, please wrap in a try-catch so that it doesn't break for users who don't have natsort installed:

try:
    from natsort import natsorted
    groups = natsorted(groups, ...)
except ImportError:
    groups = sorted(...)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants