-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement OnyxDataGridRenderer support component #1851
Comments
JoCa96
added
dev
Requires technical expertise
0-refinement
All issues that can or need to be estimated in our next refinement
labels
Sep 11, 2024
mj-hof
removed
the
0-refinement
All issues that can or need to be estimated in our next refinement
label
Sep 11, 2024
3 tasks
@JoCa96 Vacation handover:
|
larsrickert
added a commit
that referenced
this issue
Oct 1, 2024
Relates to #1851 Implement basic `OnyxDataGridRenderer` component --------- Co-authored-by: Maja Zarkova <maja.zarkova@mail.schwarz> Co-authored-by: Jonathan Carle <jonathan_leo.carle@mail.schwarz>
@larsrickert please set "striped" and "vertical border" to true as default for the data grid. Rest looks amazing :D |
1 task
larsrickert
added a commit
that referenced
this issue
Oct 8, 2024
…y default (#1905) Relates to #1851 (comment) As requested from Jannick, changed the default value for the striped and withVerticalBorders property to `true`.
1 task
JoCa96
pushed a commit
that referenced
this issue
Oct 9, 2024
Relates to #1851 Implement Playwright screenshot tests for the OnyxDataGridRenderer. ## Checklist - [x] If a new component is added, at least one [Playwright screenshot test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml) is added --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Why?
According to our #1660 we want to abstract the rendering of the OnyxDataGrid. We implement this TableRenderLayer via the
OnyxDataGridRenderer
support component.It encompasses a minimal API that renders an HTML compliant table with only permitted content elements:
The TableRenderLayer must be stateless.
Its main purpose is to create an HTML compliant table structure.
The table should be rendered according to the following rules:
columns
describes the horizontal layout of the table, every entry MUST result in a column and<th>
elementrows
describe the vertical layout of the table, every entry MUST result in a row and a<tr>
element<td>...</td>
) in a row can be any contentDesign
Figma
Acceptance criteria
OnyxDataGridRenderer
is implemented:Definition of Done
functional tests (Playwright or unit test)Approval
Implementation details
The following is the code used by the PoC of #1660.
@JoCa96 - I would consider making the
id
key dynamic. Column and row grouping, as well as styling was not yet considered.Basic structure:
Applicable ARIA Pattern
The text was updated successfully, but these errors were encountered: