Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement UX feedback for moreActions #2293

Closed
14 tasks done
MajaZarkova opened this issue Dec 10, 2024 · 1 comment
Closed
14 tasks done

Implement UX feedback for moreActions #2293

MajaZarkova opened this issue Dec 10, 2024 · 1 comment
Assignees
@MajaZarkova
Labels
dev Requires technical expertise
Milestone
Table & DataGrid

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Dec 10, 2024 •
edited by larsrickert
Loading

Open Questions/To-dos

Why?

This is a follow up ticket for #1939

Acceptance criteria

Following is implemented:

  • functional tests (Playwright or unit test)
  • If actions are added without listItems, the flyout should contain the icons
  • The flyout should open on click, not on hover

Definition of Done

  • The following component requirements are implemented:
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • covered by tests
    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly
  • Namings are aligned with Figma

Approval
@MajaZarkova MajaZarkova added this to onyx Dec 10, 2024
@MajaZarkova MajaZarkova converted this from a draft issue Dec 10, 2024
@MajaZarkova MajaZarkova self-assigned this Dec 10, 2024
@MajaZarkova MajaZarkova added the dev Requires technical expertise label Dec 10, 2024
@MajaZarkova MajaZarkova moved this from New to Backlog in onyx Dec 10, 2024
@MajaZarkova MajaZarkova added the 0-refinement All issues that can or need to be estimated in our next refinement label Dec 10, 2024
@MajaZarkova MajaZarkova mentioned this issue Dec 10, 2024
Closed
15 tasks
@mj-hof mj-hof added this to the Tables milestone Dec 10, 2024
@MajaZarkova MajaZarkova changed the title Implement OnyxDataGrid moreActions tests Implement UX feedback for OnyxDataGrid moreActions Dec 11, 2024
@mj-hof mj-hof moved this from Backlog to Ready in onyx Dec 11, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Dec 11, 2024
@MajaZarkova MajaZarkova moved this from Ready to In Progress in onyx Dec 12, 2024
@MajaZarkova MajaZarkova mentioned this issue Dec 12, 2024
Merged
2 tasks
MajaZarkova added a commit that referenced this issue Dec 16, 2024
@MajaZarkova
feat(createMenuButton): Add trigger prop on createMenuButton composab…
b76647b 
…le (#2318)

<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #2293 

<!-- Briefly describe the changes of this PR. -->

## Checklist

- [x] The added / edited code has been documented with
[JSDoc](https://jsdoc.app/about-getting-started)
- [x] A changeset is added with `npx changeset add` if your changes
should be released as npm package (because they affect the library
usage)
This was referenced Jan 13, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 14, 2025
@MajaZarkova
feat(demo-app): Add data grid example in the demo-app (#2487)
b01a711 
<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #2293 

- Add example in the demo-app
@MajaZarkova MajaZarkova moved this from In Progress to In Approval in onyx Jan 15, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2025
@MajaZarkova @github-actions
feat(OnyxDataGrid): Add screenshot test (#2493)
579dba8 
<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #2293 

Add screenshot test with header interactions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jannick-ux
Copy link
Collaborator

jannick-ux commented Jan 15, 2025 •
edited by MajaZarkova
Loading

UX findings:

  • when clicking on the "more button" again, please make it happen to close the flyout
  • Please decrease the gap between "more button" and flyout to 8px (0.5 rem)

@MajaZarkova MajaZarkova mentioned this issue Jan 15, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@MajaZarkova @github-actions
fix(OnyxFlyoutMenu): Fix OnyxFlyoutMenu opening behavior (#2516)
5210eb5 
<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #2293 

- When the flyout menu opens on click, should be closed on the second
click of the button
- Decreased the gap between "more button" and flyout to 8px (0.5 rem)

## Checklist

- [x] The added / edited code has been documented with
[JSDoc](https://jsdoc.app/about-getting-started)
- [x] All changes are documented in the documentation app (folder
`apps/docs`)
- [x] If a new component is added, at least one [Playwright screenshot
test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml)
is added
- [x] A changeset is added with `npx changeset add` if your changes
should be released as npm package (because they affect the library
usage)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Approval to Done in onyx Jan 17, 2025
@mj-hof mj-hof changed the title Implement UX feedback for OnyxDataGrid moreActions Implement UX feedback for moreActions Jan 30, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MajaZarkova MajaZarkova

Labels
dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Table & DataGrid
Development

No branches or pull requests
4 participants
@MajaZarkova @larsrickert @mj-hof @jannick-ux