Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong solver in TrustRegion tests #243

Closed
axla-io opened this issue Oct 17, 2023 · 0 comments · Fixed by #246
Closed

Wrong solver in TrustRegion tests #243

axla-io opened this issue Oct 17, 2023 · 0 comments · Fixed by #246

Comments

@axla-io
Copy link
Contributor

axla-io commented Oct 17, 2023

https://github.com/SciML/NonlinearSolve.jl/blob/7890cef696452aa94ca4ba453d791fe5bd509a12/test/basictests.jl#L228C51-L228C51

@test all(solve(probN, NewtonRaphson(; autodiff)).u .≈ sqrt(2.0))

Should be with TrustRegion instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant